Pass requestId to handlers via metadata
#358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ihrpr
approved these changes
Apr 22, 2025
|
|
||
| expect(receivedRequestId).toBeDefined(); | ||
| expect(typeof receivedRequestId === 'string' || typeof receivedRequestId === 'number').toBe(true); | ||
| expect(result.content[0].text).toContain("Received request ID:"); |
There was a problem hiding this comment.
nit: can just check the full equality as receivedRequestId is known at that point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR passes the JSON RPC request ID to the
resource,tool, andprompthandlers via theRequestHandlerExtra(extra) argument.Motivation and Context
I am maintaining the Sentry SDK and to provide observability into MCP servers we would like to be tracing requests to the MCP server.
As it stands, the tool, resource and prompt handlers live in the context of the SSE request handler, which makes it impossible to resort to
AsyncLocalStorageto associate messages to the server with the handlers.Passing the message's request ID along to the handlers allows us to correlate the POST message to the handler execution (allowing us to show users traces where the handlers are connected to the POST request). This would be great for error correlation, and also performance monitoring.
How Has This Been Tested?
I ran an MCP server locally and verified that the data is useful. Also added some tests.
Breaking Changes
No. I don't think the
RequestHandlerExtrais part of any user-facing "implementations".Types of changes
Checklist